[GitHub] paul-rogers commented on issue #1501: DRILL-6791: Scan projection framework

[GitBox]

paul-rogers commented on issue #1501: DRILL-6791: Scan projection framework
URL: https://github.com/apache/drill/pull/1501#issuecomment-445440405


@arina-ielchiieva, addressed your code review comments. Also, found and fixed a "bits" vector initialization bug. Please take another look to see if there is anything else we need to address.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

paul-rogers commented on issue #1501: DRILL-6791: Scan projection framework
URL: https://github.com/apache/drill/pull/1501#issuecomment-445595147


Builds seem flaky. My build for this change fails with:
```
TestPStoreProviders.verifyZkStore:67 » NoSuchElement
```
But, this change does not come anywhere near ZK or persistent storage.

The Travis build fails with:

```
...
[[1;34m INFO[m] artifact joda-time:joda-time: checking for updates from sonatype-apache
The job exceeded the maximum time limit for jobs, and has been terminated.
```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

paul-rogers commented on issue #1501: DRILL-6791: Scan projection framework
URL: https://github.com/apache/drill/pull/1501#issuecomment-445574835


Squashed commits and rebased on latest master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services